linux-kernel - Re: [PATCH] scsi: Fix incorrect usage of shost_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <158994171818.20861.6847855039215495249.b4-ty@oracle.com>
Date:   Tue, 19 May 2020 22:30:09 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Ye Bin <yebin10@...wei.com>, jejb@...ux.ibm.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: Fix incorrect usage of shost_for_each_device

On Mon, 18 May 2020 15:44:20 +0800, Ye Bin wrote:

> shost_for_each_device(sdev, shost) \
> 	for ((sdev) = __scsi_iterate_devices((shost), NULL); \
> 	     (sdev); \
> 	     (sdev) = __scsi_iterate_devices((shost), (sdev)))
> 
> When terminating shost_for_each_device() iteration with break or return,
> scsi_device_put() should be used to prevent stale scsi device references from
> being left behind.

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: core: Fix incorrect usage of shost_for_each_device
      https://git.kernel.org/mkp/scsi/c/4dea170f4fb2

-- 
Martin K. Petersen	Oracle Linux Engineering