linux-kernel - Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jnfeAQ4JDz+BTZp8P98h6emTizGWLYNL_QtbQ=3Nw03Q@mail.gmail.com>
Date:   Tue, 19 May 2020 17:59:15 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Domenico Andreoli <domenico.andreoli@...ux.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Pavel Machek <pavel@....cz>, Christoph Hellwig <hch@....de>,
        Al Viro <viro@...iv.linux.org.uk>, "Ted Ts'o" <tytso@....edu>,
        Len Brown <len.brown@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device

It would be better to paste the patch instead of attaching it.

Anyway, note that the snapshot special device is not the target block
device for saving the image, so it would be good to avoid that
confusion in the naming.

I.e. I would rename is_hibernate_snapshot_dev() to something like
is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency
with the resume= kernel command line parameter name).

Thanks!