linux-kernel - Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200519181713.GB1963@dumbo>
Date:   Tue, 19 May 2020 20:17:13 +0200
From:   Domenico Andreoli <domenico.andreoli@...ux.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Pavel Machek <pavel@....cz>, Christoph Hellwig <hch@....de>,
        Al Viro <viro@...iv.linux.org.uk>, Ted Ts'o <tytso@....edu>,
        Len Brown <len.brown@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device

On Tue, May 19, 2020 at 05:59:15PM +0200, Rafael J. Wysocki wrote:
> It would be better to paste the patch instead of attaching it.

Done with v2.

> Anyway, note that the snapshot special device is not the target block
> device for saving the image, so it would be good to avoid that
> confusion in the naming.

I realize that it was a bit hazy in my head as well. It should be fixed
in v2.

> 
> I.e. I would rename is_hibernate_snapshot_dev() to something like
> is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency
> with the resume= kernel command line parameter name).

Done as well.

> Thanks!

Thank you!

Dom

-- 
rsa4096: 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA  356E CC79 2832 ED38 CB05