linux-kernel - Re: [PATCH 7/8] virt: vbox: Log unknown ioctl requests as error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3fUUpixJu-jbhmhMMXP-tJYxYfLq78OUTTVaN+_c8ZwA@mail.gmail.com>
Date:   Wed, 20 May 2020 23:43:47 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/8] virt: vbox: Log unknown ioctl requests as error

On Wed, May 20, 2020 at 9:55 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Every now and then upstream adds new ioctls without notifying us,
> log unknown ioctl requests as an error to catch these.
>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/virt/vboxguest/vboxguest_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> index ffd76b949276..e0e343d0ba93 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1739,7 +1739,7 @@ int vbg_core_ioctl(struct vbg_session *session, unsigned int req, void *data)
>                 return vbg_ioctl_log(data);
>         }
>
> -       vbg_debug("VGDrvCommonIoCtl: Unknown req %#08x\n", req);
> +       vbg_err("Userspace made an unknown ioctl req %#08x\n", req);

I think these should be ratelimited to avoid spamming the console with
too many messages for something that can be trivially triggered from
user space.

       Arnd