linux-kernel - Re: [PATCH 5/8] virt: vbox: Add support for the new VBG_IOCTL_ACQUIRE_GUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1sDRsfsmPf4=Q3mG75VVNoD3CC7Rrgb4BZMEEfTu66qA@mail.gmail.com>
Date:   Wed, 20 May 2020 23:47:16 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/8] virt: vbox: Add support for the new
 VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl

On Wed, May 20, 2020 at 9:55 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl, this
> is necessary for automatic resizing of the guest resolution to match the
> VM-window size to work with the new VMSVGA virtual GPU which is now the
> new default in VirtualBox.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1789545
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>

This is not a great interface, but I see no bugs in the implementation
or problems with portability.

If you want to improve it a little bit, note that spin_lock_irqsave() inside
of mutex_lock() is a little bit silly since you know at this point that
interrupts are enabled and you could use spin_lock_irq() instead.

I assume the driver does the same thing everywhere but I did not check.

       Arnd