linux-kernel - Re: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 May 2020 11:00:15 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Bjorn Helgaas" <helgaas@...nel.org>
Cc:     "Thierry Reding" <thierry.reding@...il.com>, kjlu@....edu,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
        "Rob Herring" <robh@...nel.org>,
        "Bjorn Helgaas" <bhelgaas@...gle.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        "Vidya Sagar" <vidyas@...dia.com>,
        "Andrew Murray" <amurray@...goodpenguin.co.uk>,
        linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error

Thank you for your advice. I think tegra194 is a good choice and 
I will use it in the next edition of patch.

&quot;Bjorn Helgaas&quot; &lt;helgaas@...nel.org&gt;写道：
> On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
> > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> > > pm_runtime_get_sync() increments the runtime PM usage counter even
> > > it returns an error code. Thus a pairing decrement is needed on
> > 
> > s/even it/even when it/
> > 
> > Might also be a good idea to use a different subject prefix because I
> > was almost not going to look at the other patch, taking this to be a
> > replacement for it.
> 
> Amen.  This would be a good change to start using "PCI: tegra194" or
> something for pcie-tegra194.c.  Or will there be tegra195, tegra 196,
> etc added to this driver?
> 
> Also, please capitalize the first word and "PM" in the subjects:
> 
>   PCI: tegra194: Fix runtime PM imbalance on error
> 
> Bjorn