| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 May 2020 19:42:56 +0800 (GMT+08:00)
From: dinghao.liu@....edu.cn
To: "Dan Carpenter" <dan.carpenter@...cle.com>
Cc: kjlu@....edu, devel@...verdev.osuosl.org,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org,
"Jonathan Hunter" <jonathanh@...dia.com>,
"Thierry Reding" <thierry.reding@...il.com>,
linux-tegra@...r.kernel.org, "Dmitry Osipenko" <digetx@...il.com>,
"Mauro Carvalho Chehab" <mchehab@...nel.org>,
linux-media@...r.kernel.org
Subject: Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm
imbalance on error
We need to make sure if pm_runtime_get_sync() is designed with
such behavior before modifying it.
I received a response from Rafael when I commited a similar patch:
https://lkml.org/lkml/2020/5/20/1100
It seems that this behavior is intentional and needs to be kept.
Regards,
Dinghao
"Dan Carpenter" <dan.carpenter@...cle.com>写道：
> On Thu, May 21, 2020 at 02:27:45PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > the call returns an error code. Thus a pairing decrement is needed
> > on the error handling path to keep the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
>
> Let's stop working around the bug in pm_runtime_get_sync() and write
> a replacement for it instead.
>
> regards,
> dan carpenter
Powered by blists - more mailing lists