| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 May 2020 15:03:45 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: dinghao.liu@....edu.cn
Cc: devel@...verdev.osuosl.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kjlu@....edu,
linux-kernel@...r.kernel.org,
Jonathan Hunter <jonathanh@...dia.com>,
Thierry Reding <thierry.reding@...il.com>,
linux-tegra@...r.kernel.org, Dmitry Osipenko <digetx@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
linux-media@...r.kernel.org
Subject: Re: Re: [PATCH] [v2] media: staging: tegra-vde: fix runtime pm
imbalance on error
On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao.liu@....edu.cn wrote:
> We need to make sure if pm_runtime_get_sync() is designed with
> such behavior before modifying it.
>
> I received a response from Rafael when I commited a similar patch:
> https://lkml.org/lkml/2020/5/20/1100
> It seems that this behavior is intentional and needs to be kept.
Yes. This is why I have said twice or three times to not change
pm_runtime_get_sync() but instead to write a replacement.
A large percent of the callers are buggy. The pm_runtime_get_sync() is
a -4 on Rusty's API scale.
http://sweng.the-davies.net/Home/rustys-api-design-manifesto
One could argue that anything above a -4 is really a 2 if you read
the implementation thouroughly enough...
regards,
dan carpenter
Powered by blists - more mailing lists