linux-kernel - Re: [PATCH] scrpits: Remove unneeded assignment parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1590070442.4669.12.camel@HansenPartnership.com>
Date:   Thu, 21 May 2020 07:14:02 -0700
From:   James Bottomley <James.Bottomley@...senPartnership.com>
To:     Xu Wang <vulab@...as.ac.cn>, dhowells@...hat.com,
        dwmw2@...radead.org, keyrings@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses

On Thu, 2020-05-21 at 06:32 +0000, Xu Wang wrote:
> Remove unneeded assignment parentheses.

I really don't think this is a good idea.  Best practice for macros is
to parenthesize every argument even if there are technically some cases
where it's unnecessary because the problems in the majority cases are
huge and unexpected.

James

> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  scripts/extract-cert.c | 2 +-
>  scripts/sign-file.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/extract-cert.c b/scripts/extract-cert.c
> index b071bf476fea..8005911926b8 100644
> --- a/scripts/extract-cert.c
> +++ b/scripts/extract-cert.c
> @@ -61,7 +61,7 @@ static void drain_openssl_errors(void)
>  
>  #define ERR(cond, fmt, ...)				\
>  	do {						\
> -		bool __cond = (cond);			\
> +		bool __cond = cond;			\
>  		display_openssl_errors(__LINE__);	\
>  		if (__cond) {				\
>  			err(1, fmt, ## __VA_ARGS__);	\
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index fbd34b8e8f57..9ea08b07a0aa 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -104,7 +104,7 @@ static void drain_openssl_errors(void)
>  
>  #define ERR(cond, fmt, ...)				\
>  	do {						\
> -		bool __cond = (cond);			\
> +		bool __cond = cond;			\
>  		display_openssl_errors(__LINE__);	\
>  		if (__cond) {				\
>  			err(1, fmt, ## __VA_ARGS__);	\