linux-kernel - Re: [PATCH] scrpits: Remove unneeded assignment parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <116524.1590071315@warthog.procyon.org.uk>
Date:   Thu, 21 May 2020 15:28:35 +0100
From:   David Howells <dhowells@...hat.com>
To:     James Bottomley <James.Bottomley@...senPartnership.com>
Cc:     dhowells@...hat.com, Xu Wang <vulab@...as.ac.cn>,
        dwmw2@...radead.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses

James Bottomley <James.Bottomley@...senPartnership.com> wrote:

> > Remove unneeded assignment parentheses.
> 
> I really don't think this is a good idea.  Best practice for macros is
> to parenthesize every argument even if there are technically some cases
> where it's unnecessary because the problems in the majority cases are
> huge and unexpected.

Yep.

David