linux-kernel - Re: [PATCH v6 12/12] mmap locking API: convert mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200521102516.01dbc9fcc539baba96224c3f@linux-foundation.org>
Date:   Thu, 21 May 2020 10:25:16 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Michel Lespinasse <walken@...gle.com>
Cc:     Vlastimil Babka <vbabka@...e.cz>, linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        Matthew Wilcox <willy@...radead.org>,
        Liam Howlett <Liam.Howlett@...cle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        David Rientjes <rientjes@...gle.com>,
        Hugh Dickins <hughd@...gle.com>, Ying Han <yinghan@...gle.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

On Thu, 21 May 2020 00:50:56 -0700 Michel Lespinasse <walken@...gle.com> wrote:

> > >   * Must be called holding task's alloc_lock to protect task's mems_allowed
> > > - * and mempolicy.  May also be called holding the mmap_semaphore for write.
> > > + * and mempolicy.  May also be called holding the mmap_lockaphore for write.
> > >   */
> > >  static int mpol_set_nodemask(struct mempolicy *pol,
> > >                    const nodemask_t *nodes, struct nodemask_scratch *nsc)
> >
> > :)
> 
> Haha, good catch !

aww, you're all so cruel.  The world would be a better place if Linux
had lockaphores!