linux-kernel - Re: [PATCH -net-next] net: psample: depends on INET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUkAPF6Ks0SZuDofrcckavaLXGGvtiZJjLp51o6_Je4tw@mail.gmail.com>
Date:   Fri, 22 May 2020 12:51:31 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        Yotam Gigi <yotam.gi@...il.com>
Subject: Re: [PATCH -net-next] net: psample: depends on INET

On Fri, May 22, 2020 at 12:48 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 5/22/20 12:17 PM, Cong Wang wrote:
> > On Fri, May 22, 2020 at 12:03 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> >>
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >>
> >> Fix psample build error when CONFIG_INET is not set/enabled.
> >> PSAMPLE should depend on INET instead of NET since
> >> ip_tunnel_info_opts() is only present for CONFIG_INET.
> >>
> >> ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’:
> >> ../net/psample/psample.c:216:25: error: implicit declaration of function ‘ip_tunnel_info_opts’; did you mean ‘ip_tunnel_info_opts_set’? [-Werror=implicit-function-declaration]
> >
> > Or just make this tunnel support optional. psample does not
> > require it to function correctly.
>
> Sure, I thought of that, but it's not clear to me which bits of it
> to make optional, so I'll leave it for its maintainer to handle.

The code commit d8bed686ab96169ac80b497d1cbed89300d97f83
adds is optional, so it can be just put into #ifdef's.

Thanks.