linux-kernel - Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <278c9a47-4d68-0e0d-415d-53360337aa6c@kernel.org>
Date:   Fri, 22 May 2020 09:15:07 -0600
From:   shuah <shuah@...nel.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

On 5/22/20 9:12 AM, Mark Brown wrote:
> On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote:
>> On 5/19/20 11:44 AM, Mark Brown wrote:
> 
>>>> WARNING: Missing a blank line after declarations
>>>> WARNING: Missing a blank line after declarations
>>>> #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
>>>> +	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);
> 
>> A blank line after declarations here just like what checkpatch
>> suggests. It makes it readable.
> 
> That doesn't match the idiom used by any of the surrounding code :(
> 

I can't parse the idiom statement? Can you clarify it please.

thanks,
-- Shuah