linux-kernel - Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 16:12:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     shuah <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 3/3] selftests: vdso: Add a selftest for vDSO getcpu()

On Fri, May 22, 2020 at 08:55:50AM -0600, shuah wrote:
> On 5/19/20 11:44 AM, Mark Brown wrote:

> > > WARNING: Missing a blank line after declarations
> > > WARNING: Missing a blank line after declarations
> > > #135: FILE: tools/testing/selftests/vDSO/vdso_test_getcpu.c:27:
> > > +	unsigned long sysinfo_ehdr = getauxval(AT_SYSINFO_EHDR);

> A blank line after declarations here just like what checkpatch
> suggests. It makes it readable.

That doesn't match the idiom used by any of the surrounding code :(

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)