linux-kernel - Re: [PATCH 2/2] docs: lzo: fix incorrect statement about distance zero for EOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C3AF092B-2B39-45C9-8FE5-4069B3B34C11@arm.com>
Date:   Fri, 22 May 2020 15:22:49 +0000
From:   Dave Rodgman <dave.rodgman@....com>
To:     "C. Masloch" <pushbx@...kai.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>, Willy Tarreau <w@....eu>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] docs: lzo: fix incorrect statement about distance
 zero for EOS

Looks good to me, thanks

Dave

On 22/05/2020, 15:11, "C. Masloch" <pushbx@...kai.org> wrote:

    The encoded distance bits are zero, but the distance that is
    calculated from this is actually equal to 16384. So correct
    this statement to read that the 0001HLLL instruction means
    EOS when a distance of 16384 is seen. This matches with the
    description of the instruction itself later on.

    Signed-off-by: C. Masloch <pushbx@...kai.org>
    ---
     Documentation/lzo.txt | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/Documentation/lzo.txt b/Documentation/lzo.txt
    index f839d104d..dc9e876cb 100644
    --- a/Documentation/lzo.txt
    +++ b/Documentation/lzo.txt
    @@ -65,9 +65,9 @@ Description
       generally encoded in the last two bits of the instruction but may also be
       taken from the last two bits of an extra operand (eg: distance).

    -  End of stream is declared when a block copy of distance 0 is seen. Only one
    -  instruction may encode this distance (0001HLLL), it takes one LE16 operand
    -  for the distance, thus requiring 3 bytes.
    +  End of stream is declared when a block copy of distance 16384 is seen,
    +  encoded in a certain instruction (0001HLLL) with the H and D bits all zero.
    +  It takes one LE16 operand for the distance, thus requiring 3 bytes.

       .. important::

    --
    2.26.2


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.