[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VexCBc6iCrd_VLj5jXE8cxxdzUUf6pMG6O8LjtNj0J1Aw@mail.gmail.com>
Date: Fri, 22 May 2020 18:22:51 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dinghao Liu <dinghao.liu@....edu.cn>
Cc: Kangjie Lu <kjlu@....edu>, Laxman Dewangan <ldewangan@...dia.com>,
Mark Brown <broonie@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
linux-spi <linux-spi@...r.kernel.org>,
linux-tegra@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error
On Fri, May 22, 2020 at 6:20 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, May 22, 2020 at 10:46 AM <dinghao.liu@....edu.cn> wrote:
...
> Moreover, consider below case
>
> CPU1: ...somewhere in the code...
> pm_runtime_get() // with success!
> ...see below...
> pm_runtime_put()
>
> CPU2: ...on parallel thread...
> ret = pm_runtime_get_sync() // failed!
> if (ret)
> pm_runtime_put() // oi vei, we put device into sleep
>
> So, there is a potential issue.
...and even if it's impossible (no bugs in runtime PM core, etc) the
code with put() looks suspicious.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists