lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 May 2020 17:55:25 -0600 From: Tycho Andersen <tycho@...ho.ws> To: Sargun Dhillon <sargun@...gun.me> Cc: linux-kernel@...r.kernel.org, containers@...ts.linux-foundation.org, linux-api@...r.kernel.org, christian.brauner@...ntu.com, keescook@...omium.org, cyphar@...har.com, Jeffrey Vander Stoep <jeffv@...gle.com>, jannh@...gle.com, rsesek@...gle.com, palmer@...gle.com, Matt Denton <mpdenton@...gle.com>, Kees Cook <keescook@...gle.com> Subject: Re: [PATCH 1/5] seccomp: Add find_notification helper On Sun, May 24, 2020 at 04:39:38PM -0700, Sargun Dhillon wrote: > This adds a helper which can iterate through a seccomp_filter to > find a notification matching an ID. It removes several replicated > chunks of code. > > Signed-off-by: Sargun Dhillon <sargun@...gun.me> > Cc: Matt Denton <mpdenton@...gle.com> > Cc: Kees Cook <keescook@...gle.com>, > Cc: Jann Horn <jannh@...gle.com>, > Cc: Robert Sesek <rsesek@...gle.com>, > Cc: Chris Palmer <palmer@...gle.com> > Cc: Christian Brauner <christian.brauner@...ntu.com> > Cc: Tycho Andersen <tycho@...ho.ws> > --- > kernel/seccomp.c | 38 +++++++++++++++++++++----------------- > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/kernel/seccomp.c b/kernel/seccomp.c > index 55a6184f5990..f6ce94b7a167 100644 > --- a/kernel/seccomp.c > +++ b/kernel/seccomp.c > @@ -1021,10 +1021,25 @@ static int seccomp_notify_release(struct inode *inode, struct file *file) > return 0; > } > > +/* must be called with notif_lock held */ > +static inline struct seccomp_knotif * > +find_notification(struct seccomp_filter *filter, u64 id) > +{ > + struct seccomp_knotif *cur; > + > + list_for_each_entry(cur, &filter->notif->notifications, list) { > + if (cur->id == id) > + return cur; > + } > + > + return NULL; > +} I think there's also an instance of this in _send() that we can change to use find_notification() as well. Tycho
Powered by blists - more mailing lists