lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 May 2020 09:27:38 +0800 From: Tiezhu Yang <yangtiezhu@...ngson.cn> To: Alexandre Belloni <alexandre.belloni@...tlin.com> Cc: Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn> Subject: Re: [PATCH 1/2] rtc: goldfish: Fix return value of goldfish_rtc_probe() On 05/24/2020 03:50 AM, Alexandre Belloni wrote: > Hi, > > On 23/05/2020 17:56:21+0800, Tiezhu Yang wrote: >> When call function devm_platform_ioremap_resource(), we should use IS_ERR() >> to check the return value and return PTR_ERR() if failed. >> >> Fixes: 89576bebbc17 ("rtc: Use devm_platform_ioremap_resource()") > This doesn't fix an issue and it was anyway not introduced by that > commit. Please correct your commit message and subject. OK, thanks for your reply. I will remove the fixes tag and use the following patch subjects: "rtc: goldfish: Use correct return value for goldfish_rtc_probe()" "rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()" Thanks, Tiezhu Yang > >> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn> >> --- >> drivers/rtc/rtc-goldfish.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c >> index cb6b0ad..2779715 100644 >> --- a/drivers/rtc/rtc-goldfish.c >> +++ b/drivers/rtc/rtc-goldfish.c >> @@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, rtcdrv); >> rtcdrv->base = devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(rtcdrv->base)) >> - return -ENODEV; >> + return PTR_ERR(rtcdrv->base); >> >> rtcdrv->irq = platform_get_irq(pdev, 0); >> if (rtcdrv->irq < 0) >> -- >> 2.1.0 >>
Powered by blists - more mailing lists