linux-kernel - Re: [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200523195109.GC3429@piout.net>
Date:   Sat, 23 May 2020 21:51:09 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH 2/2] rtc: mpc5121: Fix return value of mpc5121_rtc_probe()

On 23/05/2020 17:56:22+0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
> 

Same comment here.

> Fixes: d53d4ae981d0 ("rtc: mpc5121: simplify probe")
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  drivers/rtc/rtc-mpc5121.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c
> index 3040844..5c2ce71 100644
> --- a/drivers/rtc/rtc-mpc5121.c
> +++ b/drivers/rtc/rtc-mpc5121.c
> @@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
>  	rtc->regs = devm_platform_ioremap_resource(op, 0);
>  	if (IS_ERR(rtc->regs)) {
>  		dev_err(&op->dev, "%s: couldn't map io space\n", __func__);
> -		return -ENOSYS;
> +		return PTR_ERR(rtc->regs);
>  	}
>  
>  	device_init_wakeup(&op->dev, 1);
> -- 
> 2.1.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com