linux-kernel - Re: [PATCH] serial: 8250: probe all 16550A variants by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 10:05:25 +0300
From:   Maxim Kochetkov <fido_max@...ox.ru>
To:     Josh Triplett <josh@...htriplett.org>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        jslaby@...e.com, andriy.shevchenko@...ux.intel.com,
        lukas@...ner.de, heikki.krogerus@...ux.intel.com, vigneshr@...com,
        linux-kernel@...r.kernel.org, radu-andrei.bulie@....com
Subject: Re: [PATCH] serial: 8250: probe all 16550A variants by default

This change breaks all my devices: OMAP-L138 (davinci based), LS1021A, 
T1040, Marvell (kirkwood2 based). Only enabling VARIANTS on all my 
devices fix the issue.

25.05.2020 20:28, Josh Triplett wrote:
> On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote:
>> On NXP T1040, the UART is typically detected as 16550A_FSL64. After said
>> patch, it gets detected as plain 16550A and the Linux console is
>> completely garbled and missing characters.
> Interesting that there's*new*  powerpc hardware that needs these
> variants. I based the patch on the fact that, on x86 at least, hardware
> using these variants hasn't been made for a long time.