linux-kernel - [PATCH v1] driver core: Update device link status correctly for SYNC_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200526070518.107333-1-saravanak@google.com>
Date:   Tue, 26 May 2020 00:05:17 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Saravana Kannan <saravanak@...gle.com>
Cc:     Michael Walle <michael@...le.cc>, kernel-team@...roid.com,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v1] driver core: Update device link status correctly for
 SYNC_STATE_ONLY links

When SYNC_STATE_ONLY support was added in commit 05ef983e0d65 ("driver
core: Add device link support for SYNC_STATE_ONLY flag"),
SYNC_STATE_ONLY links were treated similar to STATELESS links in terms
of not blocking consumer probe if the supplier hasn't probed yet.

That caused a SYNC_STATE_ONLY device link's status to not get updated.
Since SYNC_STATE_ONLY device link is no longer useful once the
consumer probes, commit 21c27f06587d ("driver core: Fix
SYNC_STATE_ONLY device link implementation") addresses the status
update issue by deleting the SYNC_STATE_ONLY device link instead of
complicating the status update code.

However, there are still some cases where we need to update the status
of a SYNC_STATE_ONLY device link.  A SYNC_STATE_ONLY device link can
later get converted into a normal MANAGED device link when a normal
MANAGED device link is created between a supplier and consumer that
already have a SYNC_STATE_ONLY device link between them. If a
SYNC_STATE_ONLY device link's status isn't maintained correctly till
it's converted to a normal MANAGED device link, then the normal
MANAGED device link will end up with a wrong link status. This can
cause a warning stack trace[1] when the consumer device probes.

This commit fixes the SYNC_STATE_ONLY device link status update issue
where it wouldn't transition correctly from DL_STATE_AVAILABLE to
DL_STATE_CONSUMER_PROBE.

[1] - https://lore.kernel.org/lkml/20200522204120.3b3c9ed6@apollo/
Fixes: 05ef983e0d65 ("driver core: Add device link support for SYNC_STATE_ONLY flag")
Fixes: 21c27f06587d ("driver core: Fix SYNC_STATE_ONLY device link implementation")
Reported-by: Michael Walle <michael@...le.cc>
Signed-off-by: Saravana Kannan <saravanak@...gle.com>
---
Greg,

I think this is the issue Michael ran into. I'd like him to test the fix
before it's pulled in.

Michael,

If you can test this on the branch you saw the issue in and give a
Tested-by if it works, that'd be great.

Thanks,
Saravana

 drivers/base/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 791b7530599f..9511be3f9a32 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -687,11 +687,11 @@ int device_links_check_suppliers(struct device *dev)
 	device_links_write_lock();

 	list_for_each_entry(link, &dev->links.suppliers, c_node) {
-		if (!(link->flags & DL_FLAG_MANAGED) ||
-		    link->flags & DL_FLAG_SYNC_STATE_ONLY)
+		if (!(link->flags & DL_FLAG_MANAGED))
 			continue;

-		if (link->status != DL_STATE_AVAILABLE) {
+		if (link->status != DL_STATE_AVAILABLE &&
+		    !(link->flags & DL_FLAG_SYNC_STATE_ONLY)) {
 			device_links_missing_supplier(dev);
 			ret = -EPROBE_DEFER;
 			break;
-- 
2.27.0.rc0.183.gde8f92d652-goog