linux-kernel - Re: [v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b863c03b-18f3-4942-10fd-563ab4cf5b43@web.de>
Date:   Tue, 26 May 2020 10:25:28 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     "Longpeng (Mike)" <longpeng2@...wei.com>,
        linux-crypto@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Gonglei <arei.gonglei@...wei.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in
 __virtio_crypto_skcipher_do_req()

>> I suggest to move the addition of such input parameter validation
>> to a separate update step.
>>
> Um...The 'src_nents' will be used as a loop condition,
> so validate it here is needed ?

Would you prefer to add such checking as the first update in
another small patch series?

Regards,
Markus