linux-kernel - Re: [PATCH v4 11/11] i2c: designware: Add Baikal-T1 System I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200527155239.GI1634618@smile.fi.intel.com>
Date:   Wed, 27 May 2020 18:52:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
        devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 11/11] i2c: designware: Add Baikal-T1 System I2C
 support

On Wed, May 27, 2020 at 06:04:31PM +0300, Serge Semin wrote:
> On Wed, May 27, 2020 at 05:03:03PM +0300, Andy Shevchenko wrote:
> > On Wed, May 27, 2020 at 03:01:11PM +0300, Serge Semin wrote:

...

> > > +static struct regmap_config bt1_i2c_cfg = {
> > > +	.reg_bits = 32,
> > > +	.val_bits = 32,
> > > +	.reg_stride = 4,
> > > +	.fast_io = true,
> > > +	.reg_read = bt1_i2c_read,
> > > +	.reg_write = bt1_i2c_write,
> > > +	.max_register = DW_IC_COMP_TYPE

And perhaps add a comma?

> > > +};

-- 
With Best Regards,
Andy Shevchenko