linux-kernel - Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 May 2020 15:39:48 +0200
From:   Pavel Machek <pavel@....cz>
To:     Rob Herring <robh@...nel.org>
Cc:     Dan Murphy <dmurphy@...com>, jacek.anaszewski@...il.com,
        devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings
 documention

Hi!

Thanks for reviews!

> > +additionalProperties: false
> > +...
> > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> 
> This isn't a binding file. Belongs in another patch.

These constants are directly related to the binding. It makes sense to
go in one patch...

Best regards,
								Pavel

> > index f1f718dbe0f8..846248a0693d 100644
> > --- a/drivers/leds/led-core.c
> > +++ b/drivers/leds/led-core.c
> > @@ -34,6 +34,7 @@ const char * const led_colors[LED_COLOR_ID_MAX] = {
> >  	[LED_COLOR_ID_VIOLET] = "violet",
> >  	[LED_COLOR_ID_YELLOW] = "yellow",
> >  	[LED_COLOR_ID_IR] = "ir",
> > +	[LED_COLOR_ID_MULTI] = "multicolor",
> >  };
> >  EXPORT_SYMBOL_GPL(led_colors);
> >  
> > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> > index 0ce7dfc00dcb..a463ce6a8794 100644
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -30,7 +30,8 @@
> >  #define LED_COLOR_ID_VIOLET	5
> >  #define LED_COLOR_ID_YELLOW	6
> >  #define LED_COLOR_ID_IR		7
> > -#define LED_COLOR_ID_MAX	8
> > +#define LED_COLOR_ID_MULTI	8
> > +#define LED_COLOR_ID_MAX	9
> >  
> >  /* Standard LED functions */
> >  /* Keyboard LEDs, usually it would be input4::capslock etc. */
> > -- 
> > 2.25.1
> > 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)