linux-kernel - Re: [RFC][PATCH 3/3] objtool: Add support for relocations without addends

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 09:24:14 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Matt Helsley <mhelsley@...are.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [RFC][PATCH 3/3] objtool: Add support for relocations without
 addends

On Wed, May 27, 2020 at 09:42:33AM -0700, Matt Helsley wrote:
> @@ -525,16 +556,8 @@ static int read_relocs(struct elf *elf)
>  				return -1;
>  			}
>  			memset(reloc, 0, sizeof(*reloc));
> -
> -			if (!gelf_getrela(sec->data, i, &reloc->rela)) {
> -				WARN_ELF("gelf_getrela");
> +			if (read_reloc(sec, i, reloc, &symndx))
>  				return -1;
> -			}

I try to avoid function pointers, them being slow and ugly and all.

Since it's just a single call site, I'd rather a direct call.  For
example, call read_reloc(), which has an if-then to decide which
subfunction to call.

-- 
Josh