linux-kernel - Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 14:27:05 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     jeyu@...nel.org, davem@...emloft.net, michael.chan@...adcom.com,
        dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        aelior@...vell.com, GR-everest-linux-l2@...vell.com,
        kvalo@...eaurora.org, johannes@...solutions.net,
        akpm@...ux-foundation.org, arnd@...db.de, rostedt@...dmis.org,
        mingo@...hat.com, aquini@...hat.com, cai@....pw, dyoung@...hat.com,
        bhe@...hat.com, peterz@...radead.org, tglx@...utronix.de,
        gpiccoli@...onical.com, pmladek@...e.com, tiwai@...e.de,
        schlad@...e.de, andriy.shevchenko@...ux.intel.com,
        derosier@...il.com, keescook@...omium.org, daniel.vetter@...ll.ch,
        will@...nel.org, mchehab+samsung@...nel.org, vkoul@...nel.org,
        mchehab+huawei@...nel.org, robh@...nel.org, mhiramat@...nel.org,
        sfr@...b.auug.org.au, linux@...inikbrodowski.net,
        glider@...gle.com, paulmck@...nel.org, elver@...gle.com,
        bauerman@...ux.ibm.com, yamada.masahiro@...ionext.com,
        samitolvanen@...gle.com, yzaikin@...gle.com, dvyukov@...gle.com,
        rdunlap@...radead.org, corbet@....net, dianders@...omium.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

On Wed, May 27, 2020 at 02:36:42PM -0700, Jakub Kicinski wrote:
> On Wed, 27 May 2020 03:19:18 +0000 Luis Chamberlain wrote:
> > I read your patch, and granted, I will accept I was under the incorrect
> > assumption that this can only be used by networking devices, however it
> > the devlink approach achieves getting userspace the ability with
> > iproute2 devlink util to query a device health, on to which we can peg
> > firmware health. But *this* patch series is not about health status and
> > letting users query it, its about a *critical* situation which has come up
> > with firmware requiring me to reboot my system, and the lack of *any*
> > infrastructure in the kernel today to inform userspace about it.
> > 
> > So say we use netlink to report a critical health situation, how are we
> > informing userspace with your patch series about requring a reboot?
> 
> One of main features of netlink is pub/sub model of notifications.
> 
> Whatever you imagine listening to your uevent can listen to
> devlink-health notifications via devlink. 
> 
> In fact I've shown this off in the RFC patches I sent to you, see 
> the devlink mon health command being used.

Yes but I looked at iputils2 devlink and seems I made an incorrect
assumption this can only be used for a network device rather than
a struct device.

I'll take a second look.

  Luis