linux-kernel - Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 17:04:17 +0200
From:   Bean Huo <huobean@...il.com>
To:     Bart Van Assche <bvanassche@....org>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc

On Thu, 2020-05-28 at 07:56 -0700, Bart Van Assche wrote:
> > -     buff_len = max_t(size_t, hba->desc_size.dev_desc,
> > -                      QUERY_DESC_MAX_SIZE + 1);
> > +     buff_len = QUERY_DESC_MAX_SIZE + 1;
> >        desc_buf = kmalloc(buff_len, GFP_KERNEL);
> >        if (!desc_buf) {
> >                err = -ENOMEM;
> 
> Since the buff_len variable is not changed after its initial
> assignment,
> please remove it entirely.
> 
> Thanks,
> 
> Bart.

hi, Bart

Thanks.

do you mean  like this: buff_len = hba->desc_size[id]?

Bean