[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f1e1e76ca6deb796c1ccd432d4d4dd695b812320.camel@gmail.com>
Date: Thu, 28 May 2020 18:03:52 +0200
From: Bean Huo <huobean@...il.com>
To: Avri Altman <Avri.Altman@....com>,
"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
"asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
"stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
"beanhuo@...ron.com" <beanhuo@...ron.com>,
"bvanassche@....org" <bvanassche@....org>,
"tomas.winkler@...el.com" <tomas.winkler@...el.com>,
"cang@...eaurora.org" <cang@...eaurora.org>
Cc: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
On Thu, 2020-05-28 at 14:58 +0000, Avri Altman wrote:
> Hi,
>
> > From: Bean Huo <beanhuo@...ron.com>
> >
> > At UFS initialization stage, to get the length of the descriptor,
> > ufshcd_read_desc_length() being called 6 times.
>
> May I suggest one more clarifying sentence to your commit log:
> "Instead, we will capture the descriptor size the first time we'll
> read it."
>
> > This patch is to
> > delete unnecessary reduntant code, remove ufshcd_read_desc_length()
>
> typo: redundant
fixed.
>
> > and boost UFS initialization.
> >
> > Signed-off-by: Bean Huo <beanhuo@...ron.com>
> > + if (desc_id >= QUERY_DESC_IDN_MAX) {
> > *desc_len = 0;
> > return -EINVAL;
> > }
>
> if (desc_id == QUERY_DESC_IDN_RFU_0 || desc_id ==
> QUERY_DESC_IDN_RFU_1)
> *desc_len = 0;
> else
> > +
> > + *desc_len = hba->desc_size[desc_id];
> > return 0;
> > }
> > EXPORT_SYMBOL(ufshcd_map_desc_id_to_length);
> >
> > +static void ufshcd_update_desc_length(struct ufs_hba *hba,
> > + enum desc_idn desc_id, int
> > desc_len)
>
> desc_len is at most 255 so maybe u8?
>
Avri
thanks, it will be changed in next version.
Bean
Powered by blists - more mailing lists