linux-kernel - Re: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <30cf7534-b62e-84b1-571a-945aaffac5b0@web.de>
Date:   Thu, 28 May 2020 21:48:57 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>, linux-nilfs@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kangjie Lu <kjlu@....edu>,
        Ryusuke Konishi <konishi.ryusuke@...il.com>,
        Vyacheslav Dubeyko <Vyacheslav.Dubeyko@...t.com>
Subject: Re: [PATCH] nilfs2: Fix reference count leak in
 nilfs_sysfs_create_snapshot_group()

> kobject_init_and_add() takes reference even when it fails.

It will be helpful to mention which object is referenced here, won't it?

> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object.

I guess that an imperative wording is preferred also for this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b0c3ba31be3e45a130e13b278cf3b90f69bda6f6#n151

How do you think about to combine this update step together with
“nilfs2: Fix reference count leak in nilfs_sysfs_create_device_group”
into a small patch series?
https://lore.kernel.org/patchwork/patch/1248696/
https://lore.kernel.org/lkml/20200527200933.31135-1-wu000273@umn.edu/

Regards,
Markus