linux-kernel - Re: [PATCH] [net-next] sfc: avoid an unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200528.124946.275321353658990898.davem@redhat.com>
Date:   Thu, 28 May 2020 12:49:46 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     arnd@...db.de
Cc:     linux-net-drivers@...arflare.com, ecree@...arflare.com,
        mhabets@...arflare.com, kuba@...nel.org, amaftei@...arflare.com,
        tzhao@...arflare.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next] sfc: avoid an unused-variable warning

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 27 May 2020 15:41:06 +0200

> 'nic_data' is no longer used outside of the #ifdef block
> in efx_ef10_set_mac_address:
> 
> drivers/net/ethernet/sfc/ef10.c:3231:28: error: unused variable 'nic_data' [-Werror,-Wunused-variable]
>         struct efx_ef10_nic_data *nic_data = efx->nic_data;
> 
> Move the variable into a local scope.
> 
> Fixes: dfcabb078847 ("sfc: move vport_id to struct efx_nic")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applid, thanks.