linux-kernel - Re: [PATCH 1/2] software node: implement software_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g45xJMgQ6AWgVxw0qQZw7g=jbfqNfUKpzbQre1rNYVZ5YQ@mail.gmail.com>
Date:   Thu, 28 May 2020 13:25:10 -0700
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        kernel test robot <rong.a.chen@...el.com>,
        stable <stable@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Petr Mladek <pmladek@...e.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 1/2] software node: implement software_node_unregister()

On Sun, May 24, 2020 at 8:31 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> Sometimes it is better to unregister individual nodes instead of trying
> to do them all at once with software_node_unregister_nodes(), so create
> software_node_unregister() so that you can unregister them one at a
> time.
>
> This is especially important when creating nodes in a hierarchy, with
> parent -> children representations.  Children always need to be removed
> before a parent is, as the swnode logic assumes this is going to be the
> case.
>
> Fix up the lib/test_printf.c fwnode_pointer() test which to use this new
> function as it had the problem of tearing things down in the backwards
> order.
>
> Fixes: f1ce39df508d ("lib/test_printf: Add tests for %pfw printk modifier")
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Reported-by: kernel test robot <rong.a.chen@...el.com>
> Cc: stable <stable@...r.kernel.org>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Brendan Higgins <brendanhiggins@...gle.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Petr Mladek <pmladek@...e.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Sorry, I was on vacation.

Seems like this has already been sufficiently reviewed and applied.
Nevertheless,

Tested-by: Brendan Higgins <brendanhiggins@...gle.com>