linux-kernel - Re: Re: [PATCH] hwrng: ks-sa - fix runtime pm imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70e24bdf.d2de0.1725a2125ba.Coremail.dinghao.liu@zju.edu.cn>
Date:   Thu, 28 May 2020 15:13:41 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Herbert Xu" <herbert@...dor.apana.org.au>
Cc:     "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@...ia.com>,
        "kjlu@....edu" <kjlu@....edu>, "mpm@...enic.com" <mpm@...enic.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "allison@...utok.net" <allison@...utok.net>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "rfontana@...hat.com" <rfontana@...hat.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: Re: [PATCH] hwrng: ks-sa - fix runtime pm imbalance on error

> On Wed, May 20, 2020 at 12:45:56PM -0400, stern@...land.harvard.edu wrote:
> > On Wed, May 20, 2020 at 03:42:17PM +0000, Sverdlin, Alexander (Nokia - DE/Ulm) wrote:
> > > Hello Dinghao,
> > > 
> > > On Wed, 2020-05-20 at 21:29 +0800, Dinghao Liu wrote:
> > > > pm_runtime_get_sync() increments the runtime PM usage counter even
> > > > the call returns an error code. Thus a pairing decrement is needed
> > > > on the error handling path to keep the counter balanced.
> > > 
> > > I believe, this is the wrong place for such kind of fix.
> > > pm_runtime_get_sync() has obviously a broken semantics with regards to
> > > your observation but no other driver does what you propose.
> > 
> > Look again.  For example, see what usb_autoresume_device() in 
> > drivers/usb/core/driver.c does.
> 
> However, there seems to be some disagreement as to what to do
> when pm_runtime_get_sync fails.  Your driver chooses to call
> put_sync while others prefer pm_runtime_put_noidle (e.g., see
> drivers/base/power/runtime.c).
> 
> This API does seem to be in a bit of a mess.
> 

Here I think _put_noidle() is better. It's enough for this bug
and has no side effect (e.g., _put_sync may suspend the driver).
I will send a new patch for this bug.

Regards,
Dinghao