linux-kernel - Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 12:57:03 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Zhang, Qiang" <Qiang.Zhang@...driver.com>
Cc:     Markus Elfring <markus.elfring@....de>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: 回复: [PATCH v5] workqueue:
 Remove unnecessary kfree() call in rcu_free_wq()

Guys, the patch is wrong.  The kfree is harmless when this is called
from destroy_workqueue() and required when it's called from
pwq_unbound_release_workfn().  Lai Jiangshan already explained this
already.  Why are we still discussing this?

regards,
dan carpenter