linux-kernel - Re: [PATCH] ACPI: CPPC: Fix reference count leak in acpi_cppc_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 13:49:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     wu000273@....edu
Cc:     Kangjie Lu <kjlu@....edu>, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Prashanth Prakash <pprakash@...eaurora.org>,
        Ashwin Chaugule <ashwin.chaugule@...aro.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe.

On Thu, May 28, 2020 at 12:45 AM <wu000273@....edu> wrote:
>
> From: Qiushi Wu <wu000273@....edu>
>
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Previous
> commit "b8eb718348b8" fixed a similar problem.
>
> Fixes: 158c998ea44b ("ACPI / CPPC: add sysfs support to compute delivered performance")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
>  drivers/acpi/cppc_acpi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 8b2e89c20c11..067067bc03d4 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -846,6 +846,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>                         "acpi_cppc");
>         if (ret) {
>                 per_cpu(cpc_desc_ptr, pr->id) = NULL;
> +               kobject_put(&cpc_ptr->kobj);
>                 goto out_free;
>         }
>
> --

Applied as 5.8 material, thanks!