linux-kernel - Re: [PATCH] ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 13:50:12 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     wu000273@....edu
Cc:     Kangjie Lu <kjlu@....edu>, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Toshi Kani <toshi.kani@...com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile.

On Wed, May 27, 2020 at 11:17 PM <wu000273@....edu> wrote:
>
> From: Qiushi Wu <wu000273@....edu>
>
> kobject_init_and_add() takes reference even when it fails.
> Thus, when kobject_init_and_add() returns an error,
> kobject_put() must be called to properly clean up the kobject.
>
> Fixes: 3f8055c35836 ("ACPI / hotplug: Introduce user space interface for hotplug profiles")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
>  drivers/acpi/sysfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index c60d2c6d31d6..3a89909b50a6 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -993,8 +993,10 @@ void acpi_sysfs_add_hotplug_profile(struct acpi_hotplug_profile *hotplug,
>
>         error = kobject_init_and_add(&hotplug->kobj,
>                 &acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name);
> -       if (error)
> +       if (error) {
> +               kobject_put(&hotplug->kobj);
>                 goto err_out;
> +       }
>
>         kobject_uevent(&hotplug->kobj, KOBJ_ADD);
>         return;
> --

Applied as 5.8 material, thanks!