linux-kernel - Re: [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159063101240.69627.8166973936029543160@swboyd.mtv.corp.google.com>
Date:   Wed, 27 May 2020 18:56:52 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Sivaprakash Murugesan <sivaprak@...eaurora.org>, agross@...nel.org,
        bjorn.andersson@...aro.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        robh+dt@...nel.org
Cc:     Sivaprakash Murugesan <sivaprak@...eaurora.org>
Subject: Re: [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll

Quoting Sivaprakash Murugesan (2020-05-27 05:24:52)
> Enable apss pll support.
> 
> Signed-off-by: Sivaprakash Murugesan <sivaprak@...eaurora.org>
> ---
> [V6]
>  * split the mailbox driver from this patch
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 1aa8d85..3956e44 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -300,6 +300,14 @@
>                         #mbox-cells = <1>;
>                 };
>  
> +               apsspll: clock@...6000 {
> +                       compatible = "qcom,ipq6018-a53pll";
> +                       reg = <0x0b116000 0x40>;
> +                       #clock-cells = <0>;
> +                       clocks = <&xo>;
> +                       clock-names = "xo";
> +               };
> +

I'd expect to see this inside an soc node. Also this doesn't go via clk
tree so don't send it with the clk patches.

>                 timer {
>                         compatible = "arm,armv8-timer";
>                         interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,