linux-kernel - Re: linux-next: Fixes tag needs some work in the spi-nor tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <132770930.czcBmXCZeL@192.168.0.120>
Date:   Fri, 29 May 2020 07:31:47 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <sfr@...b.auug.org.au>
CC:     <vigneshr@...com>, <linux-next@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <sergei.shtylyov@...entembedded.com>
Subject: Re: linux-next: Fixes tag needs some work in the spi-nor tree

On Friday, May 29, 2020 12:06:47 AM EEST Stephen Rothwell wrote:
> Hi all,

Hi, Stephen,

> 
> In commit
> 
>   5587fa489747 ("mtd: spi-nor: spansion: fix writes on S25FS512S")
> 
> Fixes tag
> 
>   Fixes: dfd2b74530e ("mtd: spi-nor: add Spansion S25FS512S ID")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Right. Maybe it is worth to add this kind of check in checkpatch.pl. One can 
generate the Fixes tag by adding an alias in .gitconfig:

[alias]
        fixes = show --format='Fixes: %h (\"%s\")' -s

And generate the Fixes tag with "git fixes sha1"

Cheers,
ta