[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200529102317.GA12270@e121166-lin.cambridge.arm.com>
Date: Fri, 29 May 2020 11:23:17 +0100
From: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To: Vidya Sagar <vidyas@...dia.com>,
Thierry Reding <thierry.reding@...il.com>
Cc: Bjorn Helgaas <helgaas@...nel.org>,
Dinghao Liu <dinghao.liu@....edu.cn>, kjlu@....edu,
Rob Herring <robh@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Andrew Murray <amurray@...goodpenguin.co.uk>,
linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error
On Wed, May 20, 2020 at 11:39:08PM +0530, Vidya Sagar wrote:
> Thanks for pushing a patch to fix it. I've been under the wrong assumption
> that a failing pm_runtime_get_sync() wouldn't increment the usage counter.
> With Thierry's and Bjorn's comments addressed
>
> Acked-by: Vidya Sagar <vidyas@...dia.com>
Thierry, Vidya,
are your ACKs applying also to:
https://patchwork.kernel.org/patch/11562109/
Dinghao did not carry them over and I could not understand from this
thread if your ACKs apply to both tegra and tegra194.
Thanks,
Lorenzo
> On 20-May-20 10:07 PM, Bjorn Helgaas wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
> > > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
> > > > pm_runtime_get_sync() increments the runtime PM usage counter even
> > > > it returns an error code. Thus a pairing decrement is needed on
> > >
> > > s/even it/even when it/
> > >
> > > Might also be a good idea to use a different subject prefix because I
> > > was almost not going to look at the other patch, taking this to be a
> > > replacement for it.
> >
> > Amen. This would be a good change to start using "PCI: tegra194" or
> > something for pcie-tegra194.c. Or will there be tegra195, tegra 196,
> > etc added to this driver?
> >
> > Also, please capitalize the first word and "PM" in the subjects:
> >
> > PCI: tegra194: Fix runtime PM imbalance on error
> >
> > Bjorn
> >
Powered by blists - more mailing lists