linux-kernel - Re: [PATCH] media: venus: Fix possible buffer overflow in venus_sfr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <30acaf40-3709-d712-892f-c410acd78f63@web.de>
Date:   Sat, 30 May 2020 11:44:11 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, linux-arm-msm@...r.kernel.org,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>
Subject: Re: [PATCH] media: venus: Fix possible buffer overflow in
 venus_sfr_print()

Please avoid typos in the patch subject.


> To fix this possible bug, sfr->buf_size is assigned to a local variable,
> and then this variable is checked before being used.

How do you think about a wording variant like the following?

  Thus assign the data structure member “buf_size” to a local variable
  and check it before further usage.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus