lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 May 2020 18:18:12 +0100
From:   Emil Velikov <>
To:     Sidong Yang <>
Cc:     Daniel Vetter <>,
        Haneen Mohammed <>,
        Rodrigo Siqueira <>,
        David Airlie <>,
        "Linux-Kernel@...r. Kernel. Org" <>,
        ML dri-devel <>
Subject: Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

On Sun, 31 May 2020 at 14:12, Sidong Yang <> wrote:
> Optimize looping pixels in compute_crc() and blend(). Calculate
> src_offset in start of looping horizontally and increase it.
> It's better than calculating in every pixels.
When you say "optimize" have you observed any actual benefits of the
patch - be that smaller binary, faster execution time, etc?
If there are - mentioned them in the commit message. Otherwise, it
doesn't optimise anything.

A while back, I've suggested something similar [1] mostly for cosmetic
purposes - doubt there's much benefits beyond that.


Powered by blists - more mailing lists