linux-kernel - Re: [PATCH] iommu: Improve exception handling in iommu_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f8d8308-2056-8e33-7b38-0b7d96e51c3c@web.de>
Date:   Mon, 1 Jun 2020 14:38:05 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Jörg Rödel <joro@...tes.org>,
        iommu@...ts.linux-foundation.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Improve exception handling in iommu_group_alloc()

> Optimize the error handling to free the resources correctly when
> failed to allocate an iommu group.

* I would not categorise the desired completion of exception handling
  as a software optimisation.

* Would you like to add the tag “Fixes” to the commit message?

* I suggest to avoid the specification of duplicate function calls.
  Will it be helpful to add a few jump targets?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455

Regards,
Markus