linux-kernel - Re: [PATCH] iommu: Improve exception handling in iommu_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200602015044.GA89266@VM20190228-100.tbsite.net>
Date:   Tue, 2 Jun 2020 09:50:44 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Jörg Rödel <joro@...tes.org>,
        iommu@...ts.linux-foundation.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: Improve exception handling in iommu_group_alloc()

On Mon, Jun 01, 2020 at 02:38:05PM +0200, Markus Elfring wrote:
> > Optimize the error handling to free the resources correctly when
> > failed to allocate an iommu group.
> 
> * I would not categorise the desired completion of exception handling
>   as a software optimisation.
> 
> * Would you like to add the tag “Fixes” to the commit message?

Sure.

> 
> * I suggest to avoid the specification of duplicate function calls.
>   Will it be helpful to add a few jump targets?
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455

I don't think it is helpful or readable to add some jump targets here, since the exception handling is very simple here.