linux-kernel - RE: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Jun 2020 17:08:55 +0000
From:   "Brown, Aaron F" <aaron.f.brown@...el.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Lifshits, Vitaly" <vitaly.lifshits@...el.com>
CC:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function
 warning

> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Arnd
> Bergmann
> Sent: Wednesday, May 27, 2020 6:47 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; David S. Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Lifshits, Vitaly
> <vitaly.lifshits@...el.com>
> Cc: Arnd Bergmann <arnd@...db.de>; Konstantin Khlebnikov
> <khlebnikov@...dex-team.ru>; netdev@...r.kernel.org; Wysocki, Rafael J
> <rafael.j.wysocki@...el.com>; linux-kernel@...r.kernel.org; intel-wired-
> lan@...ts.osuosl.org; Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function
> warning
> 
> The CONFIG_PM_SLEEP #ifdef checks in this file are inconsistent,
> leading to a warning about sometimes unused function:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:137:13: error: unused function
> 'e1000e_check_me' [-Werror,-Wunused-function]
> 
> Rather than adding more #ifdefs, just remove them completely
> and mark the PM functions as __maybe_unused to let the compiler
> work it out on it own.
> 
> Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
Tested-by: Aaron Brown <aaron.f.brown@...el.com>