linux-kernel - Re: [PATCH v2] afs: Fix memory leak in afs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1346217.1591031323@warthog.procyon.org.uk>
Date:   Mon, 01 Jun 2020 18:08:43 +0100
From:   David Howells <dhowells@...hat.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     dhowells@...hat.com, Zhihao Cheng <chengzhihao1@...wei.com>,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yi Zhang <yi.zhang@...wei.com>
Subject: Re: [PATCH v2] afs: Fix memory leak in afs_put_sysnames()

Markus Elfring <Markus.Elfring@....de> wrote:

> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
> 
> How do you think about a wording variant like the following?
> 
>    Release the sysnames object after its reference counter was decreased
>    to zero.

I would say "reference count" not "reference counter" personally.  I would
also say "afs_sysnames" rather than "sysnames".  Perhaps something like:

	Fix afs_put_sysnames() to actually free the specified afs_sysnames
	object after its reference count has been decreased to zero and its
	contents have been released.

> Will it matter to mention the size of the data structure "afs_sysnames"?

Why is it necessary to do so?

David