linux-kernel - Re: tegra124-jetson-tk1: sata doesnt work since 5.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56700c1d-ffb0-e44e-ea8e-48a848ccf3bf@gmail.com>
Date:   Wed, 3 Jun 2020 01:49:57 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     LABBE Corentin <clabbe@...libre.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        pgaikwad@...dia.com, pdeschrijver@...dia.com,
        mturquette@...libre.com, sboyd@...nel.org, axboe@...nel.dk,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: tegra124-jetson-tk1: sata doesnt work since 5.2

02.06.2020 11:19, LABBE Corentin пишет:
...
>> Sounds like PLLE needs to be enabled for SATA, but ahci-tegra driver
>> doesn't do that.
>>
>> Could you please try this change:
>>
>> --- >8 ---
>> diff --git a/drivers/clk/tegra/clk-tegra124.c
>> b/drivers/clk/tegra/clk-tegra124.c
>> index e931319dcc9d..7dbc14652830 100644
>> --- a/drivers/clk/tegra/clk-tegra124.c
>> +++ b/drivers/clk/tegra/clk-tegra124.c
>> @@ -1330,6 +1330,7 @@ static struct tegra_clk_init_table
>> common_init_table[] __initdata = {
>>  	{ TEGRA124_CLK_I2S3_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>>  	{ TEGRA124_CLK_I2S4_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>>  	{ TEGRA124_CLK_VIMCLK_SYNC, TEGRA124_CLK_CLK_MAX, 24576000, 0 },
>> +	{ TEGRA124_CLK_PLL_E, TEGRA124_CLK_CLK_MAX, 0, 1 },
>>  	/* must be the last entry */
>>  	{ TEGRA124_CLK_CLK_MAX, TEGRA124_CLK_CLK_MAX, 0, 0 },
>>  };
>> --- >8 ---
> 
> This patch alone does not fix the issue.

I'd try to enable all the clocks and voltage regulators that are enabled
by the USB driver. Also won't hurt to check the clock rate
configurations with the enabled / disabled USB, try to replicate the
working configuration.