linux-kernel - Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200602094947.GA5684@sirena.org.uk>
Date:   Tue, 2 Jun 2020 10:49:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-spi@...r.kernel.org, Navid Emamdoost <emamd001@....edu>,
        Kangjie Lu <kjlu@....edu>, Stephen McCamant <smccaman@....edu>,
        Qiushi Wu <wu000273@....edu>,
        Dinghao Liu <dinghao.liu@....edu.cn>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get
 failure

On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote:
> > The counter is incremented via pm_runtime_get even in failure case.
> > To correct the counter call pm_runtime_put in case of failure, too.
> 
> How do you think about a wording variant like the following?
> 
>    Change description:
>    The PM runtime reference counter is generally incremented by a call of
>    the function “pm_runtime_get_sync”.
>    Thus call the function “pm_runtime_put_autosuspend” also in one error case
>    to keep the reference counting consistent.

The original changelog is perfectly fine, please stop sending these.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)