linux-kernel - Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c68e435a-30f7-c7ba-ec2e-93bcb17d2d26@huawei.com>
Date:   Wed, 3 Jun 2020 09:39:15 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     <linus.walleij@...aro.org>, <baohua@...nel.org>,
        <yuping.luo@....com>, <Markus.Elfring@....de>
CC:     <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>
Subject: Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in
 sirfsoc_gpio_probe()

On 2020/6/3 9:35, yu kuai wrote:
> A coccicheck run provided information like the following:
> 
> drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 792, but without a corresponding
> object release within this function.
> 
> Generated by: scripts/coccinelle/free/put_device.cocci
> 
> Thus add a jump target to fix the exception handling for this
> function implementation.
> 
> Fixes: 5130216265f6 ("PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII")
> Signed-off-by: yu kuai <yukuai3@...wei.com>
> ---
>   drivers/pinctrl/sirf/pinctrl-sirf.c | 20 ++++++++++++++------
>   1 file changed, 14 insertions(+), 6 deletions(-)
Sorry about the missing change log:

Changes in V2:
  change the variant of commit message suggested by Markus.

Best Regards,
Yu Kuai