linux-kernel - Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYgUCek0WGzqKqH7XzvDaKGK2po7cJse5LG9ahfBQCYZQ@mail.gmail.com>
Date:   Wed, 3 Jun 2020 14:32:53 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     yu kuai <yukuai3@...wei.com>
Cc:     Barry Song <baohua@...nel.org>, Yuping Luo <yuping.luo@....com>,
        Markus Elfring <Markus.Elfring@....de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        yi.zhang@...wei.com
Subject: Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio_probe()

On Wed, Jun 3, 2020 at 3:36 AM yu kuai <yukuai3@...wei.com> wrote:

> A coccicheck run provided information like the following:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
> call of_find_device_by_node on line 792, but without a corresponding
> object release within this function.
>
> Generated by: scripts/coccinelle/free/put_device.cocci
>
> Thus add a jump target to fix the exception handling for this
> function implementation.
>
> Fixes: 5130216265f6 ("PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII")
> Signed-off-by: yu kuai <yukuai3@...wei.com>

Patch applied, thanks!

Yours,
Linus Walleij