[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200603015808.GS23230@ZenIV.linux.org.uk>
Date: Wed, 3 Jun 2020 02:58:08 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Namjae Jeon <namjae.jeon@...sung.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
syzkaller@...glegroups.com, butterflyhuangxx@...il.com,
sj1557.seo@...sung.com, stable@...r.kernel.org
Subject: Re: [PATCH] exfat: fix memory leak in exfat_parse_param()
On Wed, Jun 03, 2020 at 10:29:57AM +0900, Namjae Jeon wrote:
> exfat_free() should call exfat_free_iocharset() after stealing
> param->string instead of kstrdup in exfat_parse_param().
ITYM
extfat_free() should call exfat_free_iocharset(), to prevent
a leak in case we fail after parsing iocharset= but before calling
get_tree_bdev()
Additionally, there's no point copying param->string in
exfat_parse_param() - just steal it, leaving NULL in param->string.
That's independent from the leak or fix thereof - it's simply
avoiding an extra copy.
Powered by blists - more mailing lists