linux-kernel - RE: [PATCH] exfat: fix memory leak in exfat_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <015501d6394c$fa4aeb80$eee0c280$@samsung.com>
Date:   Wed, 3 Jun 2020 11:16:23 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Al Viro'" <viro@...iv.linux.org.uk>
Cc:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <syzkaller@...glegroups.com>, <butterflyhuangxx@...il.com>,
        <sj1557.seo@...sung.com>, <stable@...r.kernel.org>
Subject: RE: [PATCH] exfat: fix memory leak in exfat_parse_param()

> On Wed, Jun 03, 2020 at 10:29:57AM +0900, Namjae Jeon wrote:
> 
> > exfat_free() should call exfat_free_iocharset() after stealing
> > param->string instead of kstrdup in exfat_parse_param().
> 
> ITYM
> 	extfat_free() should call exfat_free_iocharset(), to prevent a leak in case we fail after
> parsing iocharset= but before calling
> get_tree_bdev()
> 
> 	Additionally, there's no point copying param->string in
> exfat_parse_param() - just steal it, leaving NULL in param->string.
> That's independent from the leak or fix thereof - it's simply avoiding an extra copy.
Updated it in v2.
Thanks!